Subject: [htdig3-dev] Re: max_keywords works as expected;)
From: Gilles Detillieux (grdetil@scrc.umanitoba.ca)
Date: Tue Dec 14 1999 - 13:37:02 PST
According to Joe R. Jah:
> This whole confusion had closed my eyes to the fact that htdig was dumping
> core all the time and I was not noticing it;( Last night after several
> trial and errors I realized that your version of local duplicate
> suppression patch,
> ftp://sol.ccsf.cc.ca.us/htdig-patches/3.1.4/Retriever.cc.0,
> lacked one "return TRUE;" statement that was causing my htdig to dig
> almost all the documents and silently dump core, leaving just two dozen
> documents undug. Everything else would work, except an obscure error
> message among the usual bad links, and a six meg core file in htdig
> directory;) I added the statement to the patch, recompiled and randig;
> everything worked fine:
>
> + }
> + visited.Add(key,local_filename);
> *+ return TRUE;*
> + }
>
> I have patched the patch in the patch site;)
Oops. If you're going to add a line to a patch, you need to bump up the
line count for that section, in this case from 36 to 37. You may also
want to remove the now inappropriate sentence...
I removed the "return TRUE;"
after the visited.Add() call, which would have caused a memory leak as it
didn't delete the local_filename at that point.
This was a poorly thought out last minute change. I keep forgetting that
when you add a string to a Dictionary, you can't delete it afterward. Of
course there was no memory leak there before, and my change broke the code.
Sorry about that.
-- Gilles R. Detillieux E-mail: <grdetil@scrc.umanitoba.ca> Spinal Cord Research Centre WWW: http://www.scrc.umanitoba.ca/~grdetil Dept. Physiology, U. of Manitoba Phone: (204)789-3766 Winnipeg, MB R3E 3J7 (Canada) Fax: (204)789-3930------------------------------------ To unsubscribe from the htdig3-dev mailing list, send a message to htdig3-dev-unsubscribe@htdig.org You will receive a message to confirm this.
This archive was generated by hypermail 2b28 : Tue Dec 14 1999 - 13:50:46 PST