Subject: Re: [htdig3-dev] Owwwww htdig core FOUND IT
From: Gilles Detillieux (grdetil@scrc.umanitoba.ca)
Date: Thu Dec 09 1999 - 08:57:26 PST
According to Geoff Hutchison:
> At 11:00 AM -0400 12/9/99, Daniel MacKay wrote:
> >It does that if you start in -l mode but haven't specified an url_log.
> >...
> > >is this familiar? Is there a patch I should have?
>
> Great! Thanks for the bug report. Alas, it won't make 3.1.4 since
> that's literally about to be released in a few hours. But we'll make
> sure it's fixed in the next release.
Actually, if you don't specify an url_log, it uses the default, which
is ${database_dir}/db.log. If that file doesn't exist, the assertion
is never called. The way I read the code, the assert will fail only
when a line longer than 1000 bytes is read from the url_log file.
Of course, this is not the proper place for an assert() call in
production code - these should be limited to places where failure is
almost impossible, and recovery is impossible. A long line is not
such a problem. We really should go through and fix places in the code
that don't deal with long lines correctly. (I know there are others.)
A String::getline() method, or similar operator, could be used in all
these situations to avoid static buffer length restrictions.
-- Gilles R. Detillieux E-mail: <grdetil@scrc.umanitoba.ca> Spinal Cord Research Centre WWW: http://www.scrc.umanitoba.ca/~grdetil Dept. Physiology, U. of Manitoba Phone: (204)789-3766 Winnipeg, MB R3E 3J7 (Canada) Fax: (204)789-3930------------------------------------ To unsubscribe from the htdig3-dev mailing list, send a message to htdig3-dev-unsubscribe@htdig.org You will receive a message to confirm this.
This archive was generated by hypermail 2b28 : Thu Dec 09 1999 - 09:10:35 PST