Subject: Re: [htdig3-dev] Patch for Ht://Dig v3.1.3
From: Geoff Hutchison (email@example.com)
Date: Fri Nov 26 1999 - 08:53:00 PST
At 12:48 PM +0300 11/26/99, Alexis Mikhailov wrote:
>This variable was added to allow index of local files with NOINDEX tag.
>For example, all Qt documentation files contain this tag. I thought
>it would be not interesting to remove this tag in every file by hand,
>so I created this variable. Forgot about default value though.
Hmm. Now there's a problem. Obviously I can see a need for indexing
local files with NOINDEX, but I think it could open up a nasty can of
worms if it's allowed on the web. I guess the easiest way is to check
whether the access is local or not. Maybe the local access methods
temporarily allow it, then disallow when they're done?
>This option was added to simplify calling of htsearch from external
>program. Of course it was possible to set enviroment variables to
>CGI call, but it seemed unnecessary complicated.
I never thought it was that complicated, but it seems fairly harmless.
> > 8) htsearch/Display.cc: compare nPages to maximum_pages earlier than was
> > done before, presumably so PAGES variable won't be allowed to exceed it.
>Also to not display '1', '2' etc. buttons in the end of page if
>maximum_pages = 1.
Very good point. I'm actually a bit surprised no one noticed this bug
> > operator added to the String class in (4) above, given the way it pokes
> > into internals of library classes, and the unfamiliar cast construct.
>Copied from STL, should be portable.
I think Gilles is wondering whether it'll be portable to a system
that *doesn't* use GNU libstc++ as their library. We probably won't
know that until it comes up. I'm also wondering about Joe's
report--it looks like the String class is having memory issues.
>Sorry again, I'm still new to working with community.
>PS. Sorry for weak English
You don't really need to apologize. We have lots of international
contributors and we understand that you're new. We're just trying to
get you up to speed.
>Well, first I wanted to ask developers will they be willing to
>include all this changes. If some change is to be included
>I would like to commit it to CVS. If some other change is not
>satisfactory I would like to be given some hint how to rework it.
To be honest, I'm usually a bit hesitant to give CVS write access out
without seeing a patch or two and having a current developer put them
in. For example, I'd like to see the Display.cc changes (it's a bug
fix), but with Joe's report, I'm hesitant about the String.cc changes.
> > Would you be willing to adapt this to the current CVS tree?
>Of course, but I would need write access to CVS.
I was referring more to adapting it to fit in with the 3.2 tree. For
that you don't really need write access. Nevertheless, if you haven't
been assigned a CVS account, you'll need to fill out the form at
To unsubscribe from the htdig3-dev mailing list, send a message to
You'll receive a message confirming the unsubscription.
This archive was generated by hypermail 2b25 : Fri Nov 26 1999 - 09:05:18 PST