[htdig3-dev] Leak in 3.1.3 + patch

loic@ceic.com
Fri, 24 Sep 1999 19:52:30 +0200 (MEST)

       Hi,

       I ran purify thru 3.1.3 htdig command. Looking at the leaks,
the most proeminent is in Join. It leaks 500 bytes when crawling the 5
files from the test directory of 3.2. I'd say that we should probably
take the String and HtVector classes from 3.2. But the constness
they now have will require a *lot* of changes everywhere.

*** StringList.cc.~1~ Wed Sep 22 17:18:43 1999
--- StringList.cc Fri Sep 24 19:23:34 1999
***************
*** 295,308 ****
  
  String StringList::Join(char sep)
  {
! String *str = new String();
    int i;
  
    for (i=0; i < number; i++)
    {
! if (str->length())
! str->append(sep);
! str->append(*((String *) Nth(i)));
    }
! return *str;
  }
--- 295,308 ----
  
  String StringList::Join(char sep)
  {
! String str("");
    int i;
  
    for (i=0; i < number; i++)
    {
! if (str.length())
! str.append(sep);
! str.append(*((String *) Nth(i)));
    }
! return str;
  } 

-- 
		Loic Dachary

		ECILA
		100 av. du Gal Leclerc
		93500 Pantin - France
		Tel: 33 1 56 96 09 80, Fax: 33 1 56 96 09 61
		e-mail: Loic@Dachary.org URL: http://www.senga.org/

------------------------------------
To unsubscribe from the htdig3-dev mailing list, send a message to
htdig3-dev@htdig.org containing the single word "unsubscribe" in
the SUBJECT of the message.

This archive was generated by hypermail 2.0b3 on Fri Sep 24 1999 - 10:43:13 PDT