Gilles Detillieux (grdetil@scrc.umanitoba.ca)
Wed, 27 Jan 1999 17:12:05 -0600 (CST)
While looking over how various string lists are handled in the code,
I stumbled onto what looks like a bug in htsearch/Display.cc, in its
handling of the star_patterns attribute. It's not advancing tokens
in pairs correctly, so instead of turning a list of "1 2 3 4" into
the mappings 1->2, 3->4, it seems instead it would generate 1->2,
2->3, 3->4. It probably never showed up, because the even entries in
the list are .gif file names, which would never match URLs that the
search found, but there's no point in generating the superfluous mappings.
Here's a trivial fix:
--- ./htsearch/Display.cc.starfix Tue Jan 26 15:45:38 1999
+++ ./htsearch/Display.cc Wed Jan 27 17:01:08 1999
@@ -775,6 +775,8 @@
//
token = strtok(0, " \t\r\n");
URLimageList.Add(new String(token));
+ if (token)
+ token = strtok(0, " \t\r\n");
}
pattern.chop(1);
URLimage.Pattern(pattern);
Geoff, once all the recent patches are in the source tree, could you please
make another snapshot, so I can do further testing of the latest changes?
Thanks.
-- Gilles R. Detillieux E-mail: <grdetil@scrc.umanitoba.ca> Spinal Cord Research Centre WWW: http://www.scrc.umanitoba.ca/~grdetil Dept. Physiology, U. of Manitoba Phone: (204)789-3766 Winnipeg, MB R3E 3J7 (Canada) Fax: (204)789-3930 ------------------------------------ To unsubscribe from the htdig3-dev mailing list, send a message to htdig3-dev@htdig.org containing the single word "unsubscribe" in the SUBJECT of the message.
This archive was generated by hypermail 2.0b3 on Thu Feb 04 1999 - 22:24:20 PST